Modernize GitHub actions and declare MSRV #17
Conversation
sourcefrog
changed the title
sourcefrog
force-pushed
the
ci
branch
2 times, most recently
from
33a4a2e to
1539e2c
Compare
Remove use of deprecated actions-rs
Supported by every toolchain that we support, and doesn't actually require any changes to the codebase.
Seems to be the earliest version that actually builds.
| keywords = ["patch", "diff", "parse", "nom"] | ||
| license = "MIT" | ||
| edition = "2018" | ||
| edition = "2021" |
There was a problem hiding this comment.
I was mindful of updating the edition as I've been bitten by packages pushing mindlessly forward interfering with (embedded) platforms with limitations keeping rust versions older, which is why I kept it back.
Its probably time to move on though.
There was a problem hiding this comment.
Right, I wouldn't want to move forward unnecessarily. However it seems that the oldest compiler that works with our dependencies also supports 2021, and it's from June 2021.
There was a problem hiding this comment.
Pull request overview
This PR modernizes the GitHub Actions workflow configuration and establishes a formal Minimum Supported Rust Version (MSRV) of 1.71. It consolidates CI jobs for better efficiency, updates to Rust edition 2021, and replaces deprecated GitHub Actions to comply with current best practices.
- Declares MSRV as 1.71 in Cargo.toml and tests it in CI
- Consolidates separate "test" and "style" jobs into a single job, adding nightly testing
- Updates Rust edition from 2018 to 2021 with corresponding code modernization
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Updates edition to 2021 and declares rust-version 1.71 |
| .github/workflows/checks.yml | Replaces deprecated actions (actions-rs/toolchain, actions-rs/cargo), consolidates jobs, adds MSRV and nightly testing |
| src/ast.rs | Modernizes test code to use array literal instead of vec![] macro |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
Fixes some warnings about using deprecated commands: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/