-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Copy link
Labels
aspect: browser IDEeditor: code (browser)meta: never-staleThis issue can never become staleThis issue can never become staleteam: IDEtype: improvementImproves an existing feature or existing codeImproves an existing feature or existing code
Description
Bug description
Back in #8783, we introduced a warning alert to notify users when they've opted in for using the latest editor release for workspaces.
This is also shown on the workspace pages like Timed Out, Stopping, Stopped which can be inaccurate as the user may have changed the setting in the meantime.
Instead, relying on showing this warning during workspace (re)start could be better.
When the latest warning should be shown
- It's before or (re)starting the workspace -> ref to phases
gitpod/components/dashboard/src/start/StartPage.tsx
Lines 26 to 50 in 9d2d729
function getPhaseTitle(phase?: StartPhase, error?: StartWorkspaceError) { if (!!error) { return "Oh, no! Something went wrong!"; } switch (phase) { case StartPhase.Checking: return "Checking"; case StartPhase.Preparing: return "Preparing"; case StartPhase.Creating: return "Creating"; case StartPhase.Starting: return "Starting"; case StartPhase.Running: return "Starting"; case StartPhase.IdeReady: return "Running"; case StartPhase.Stopping: return "Stopping"; case StartPhase.Stopped: return "Stopped"; default: return ""; } } - Workspaces start/stopped failed for some unexpected reasons (i.e. with exit code from supervisor) -> when it shows error
{error && <StartError error={error} />}
Steps to reproduce
- Go to /preferences and opt in for the Latest Release (Unstable) option.
- Open a new workspace and let it time out (~30 min)
- Notice the on the Timed Out page we're still showing the latest editor release warning alert.
Metadata
Metadata
Assignees
Labels
aspect: browser IDEeditor: code (browser)meta: never-staleThis issue can never become staleThis issue can never become staleteam: IDEtype: improvementImproves an existing feature or existing codeImproves an existing feature or existing code
