Hide the latest editor warning on stopping/stopped phases of a workspace #16940

Devansu-Yadav · 2023-03-21T12:04:10Z

Description

Removes the latest ide alert warning on the workspace stopping and stopped pages and only shows it during workspace (re)start.

Related Issue(s)

How to test

Release Notes

Removes the latest ide alert warning on the workspace stopping and stopped pages

Documentation

Build Options:

/werft with-werft
Run the build with werft instead of GHA
leeway-no-cache
/werft no-test
Run Leeway with --dont-test

Publish Options

/werft publish-to-npm
/werft publish-to-jb-marketplace

Installer Options

with-ee-license
with-dedicated-emulation
with-ws-manager-mk2
workspace-feature-flags
Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-large-vm
/werft with-gce-vm
If enabled this will create the environment on GCE infra
/werft with-integration-tests=all
Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

werft-gitpod-dev-com · 2023-03-21T12:04:13Z

annotations in the pull request changed, but user is not allowed to start a job

Devansu-Yadav · 2023-03-21T12:08:19Z

Some context 💡 - This PR is created as per @mustard-mh's comment in #16551 to hide this warning for the workspace Stopping and Stopped phases.

mustard-mh · 2023-03-21T14:43:35Z

Hey, @Devansu-Yadav Thank you for your follow-up contribution 🙏 I'd like to suggest the following conditions to show/hide this alert to close the issue #11035

Show if the workspace stopped or failed to start because of some unexpected errors (in case it failed due to the latest IDEs)
Hide if its phase is after running

The issue description #11035 has some code refers. Please let me know if you have any questions or suggestions.

Devansu-Yadav · 2023-03-23T11:57:53Z

I'd like to suggest the following conditions to show/hide this alert to close the issue #11035

Show if the workspace stopped or failed to start because of some unexpected errors (in case it failed due to the latest IDEs)

@mustard-mh I have pushed a change to address this. Could you please have a look and let me know if it's the correct way to do it?

Hide if its phase is after running

I think the very first change in this PR should address this. We now hide the alert on Stopping, Stopped, and TimeOut, which are the phases after Running.

mustard-mh · 2023-03-24T16:28:02Z

components/dashboard/src/start/StartWorkspace.tsx

+                phase={phase}
+                error={error}
+                title={title}
+                showLatestIdeWarning={isError || (!isTimedOut && !isStoppingOrStopped && useLatest)}


Suggested change

showLatestIdeWarning={isError || (!isTimedOut && !isStoppingOrStopped && useLatest)}

showLatestIdeWarning={useLatest && (isError || (!isTimeout && !isStoppingOrStopped))}

But it would be good to name isTimeout and isStoppingOrStopped together (I can't find a proper name for it XD).

@mustard-mh Do you mean we should combine both the variables isTimeout and isStoppingOrStopped?

@mustard-mh Actually, we can just remove the isTimeout variable entirely since it's just a special case under the Stopping phase, and we anyways want to hide this alert for any phases after Running. We could keep the isStoppingorStopped variable as is.

@mustard-mh Could you help or confirm if what @Devansu-Yadav is suggesting above is ok? 🏓

mustard-mh Could you help or confirm if what Devansu-Yadav is suggesting above is ok? 🏓

From the code, yes 👍

Thanks, @mustard-mh! Let me loop in @gitpod-io/engineering-webapp to bring this up to the team attention in case this could be ready to merge.

mustard-mh · 2023-03-24T16:29:24Z

/werft run

👍 started the job as gitpod-build-hide-editor-warning-fork.0
(with .werft/ from main)

werft-gitpod-dev-com · 2023-03-24T16:29:38Z

started the job as gitpod-build-hide-editor-warning.0 because the annotations in the pull request description changed
(with .werft/ from main)

gtsiolis · 2023-03-31T07:58:07Z

Deployed a preview environment in https://hide-editor-warning.preview.gitpod-dev.com/workspaces.

Devansu-Yadav · 2023-04-11T14:08:51Z

@gtsiolis Any updates on this PR?

gtsiolis · 2023-04-11T16:05:17Z

@Devansu-Yadav Let me loop in @gitpod-io/engineering-webapp to take a closer look at the recent[1] code changes.

stale · 2023-05-01T16:22:11Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Devansu-Yadav · 2023-05-22T11:41:11Z

@gtsiolis Could you pls re-open this PR?

@Devansu-Yadav Let me loop in @gitpod-io/engineering-webapp to take a closer look at the recent[1] code changes.

Seems like there hasn't been any update since this 😅

gtsiolis · 2023-05-22T11:43:45Z

Sure, @Devansu-Yadav.

Thanks for hanging here! 🙏

Let me re-loop in @gitpod-io/engineering-webapp.

stale · 2023-06-17T23:06:24Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

akosyakov · 2023-07-24T05:25:16Z

@gtsiolis Do you know what is blocking it?

gtsiolis · 2023-07-24T09:13:27Z

@akosyakov Unless code changes are no longer applicable, changes should be good to merge since @mustard-mh reviewed this a while ago, see #16940 (comment). 🏓

The problem with merging this is that we no longer can merge community contributions directly from PRs, see relevant section (internal) from our handbook:

Until we completely switch to GitHub Actions, merging community contributions from forks is not possible. A workaround for now is to adjust the PR from the fork to merge into a branch we create instead of main first and open a separate PR to merge the changes into main. See SID-104 for more context.

Let me merge this in a branch and reopen. ➰

…6940)

…6940) (#18336) Co-authored-by: Devansu Yadav <devansuyadav@gmail.com>

Devansu-Yadav requested a review from a team March 21, 2023 12:04

Devansu-Yadav requested a review from gtsiolis as a code owner March 21, 2023 12:04

roboquat added the release-note label Mar 21, 2023

roboquat added the size/S label Mar 21, 2023

gtsiolis added the community-contribution label Mar 21, 2023

Devansu-Yadav force-pushed the hide-editor-warning branch from a2e0435 to 2a1a78b Compare March 23, 2023 11:51

Devansu-Yadav changed the title ~~[workspace] hide ide alert on stop phase (#11035)~~ Hide the latest editor warning on stopping or stopped phases of a workspace Mar 23, 2023

Devansu-Yadav changed the title ~~Hide the latest editor warning on stopping or stopped phases of a workspace~~ Hide the latest editor warning on stopping/stopped phases of a workspace Mar 23, 2023

mustard-mh reviewed Mar 24, 2023

View reviewed changes

Devansu-Yadav force-pushed the hide-editor-warning branch from 2a1a78b to 4489026 Compare March 28, 2023 07:55

Devansu-Yadav force-pushed the hide-editor-warning branch from 435e26c to 7489e49 Compare April 4, 2023 06:18

Devansu-Yadav force-pushed the hide-editor-warning branch from 7489e49 to e0dbe89 Compare April 11, 2023 14:08

Devansu-Yadav force-pushed the hide-editor-warning branch from e0dbe89 to 611cfea Compare April 18, 2023 12:21

stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 1, 2023

stale bot closed this May 8, 2023

gtsiolis reopened this May 22, 2023

stale bot removed meta: stale This issue/PR is stale and will be closed soon labels May 22, 2023

Devansu-Yadav added 3 commits June 5, 2023 11:29

[workspace] hide ide alert on stop phase (gitpod-io#11035)

d1ac344

[workspace] show ide alert on errors (gitpod-io#11035)

3e8d57d

[workspace] refactor code for showing ide alert

7a0e999

Devansu-Yadav force-pushed the hide-editor-warning branch from 522dfd0 to 7a0e999 Compare June 5, 2023 11:30

stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jun 17, 2023

gtsiolis requested review from a team and removed request for a team July 21, 2023 16:26

stale bot removed meta: stale This issue/PR is stale and will be closed soon labels Jul 21, 2023

gtsiolis changed the base branch from main to gt/merge-16940 July 24, 2023 09:14

gtsiolis merged commit b3851d8 into gitpod-io:gt/merge-16940 Jul 24, 2023

gtsiolis mentioned this pull request Jul 24, 2023

Hide the latest editor warning for stopping or stopped workspaces #18336

Merged

14 tasks

gtsiolis pushed a commit that referenced this pull request Aug 9, 2023

Hide the latest editor warning for stopping or stopped workspaces (#1…

ed2aca4

…6940)

roboquat pushed a commit that referenced this pull request Aug 28, 2023

Hide the latest editor warning for stopping or stopped workspaces (#1…

f92950f

…6940) (#18336) Co-authored-by: Devansu Yadav <devansuyadav@gmail.com>

	showLatestIdeWarning={isError \|\| (!isTimedOut && !isStoppingOrStopped && useLatest)}
	showLatestIdeWarning={useLatest && (isError \|\| (!isTimeout && !isStoppingOrStopped))}

Hide the latest editor warning on stopping/stopped phases of a workspace #16940

Hide the latest editor warning on stopping/stopped phases of a workspace #16940

Uh oh!

Conversation

Devansu-Yadav commented Mar 21, 2023 • edited by mustard-mh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

How to test

Release Notes

Documentation

Build Options:

Preview Environment Options:

Uh oh!

werft-gitpod-dev-com bot commented Mar 21, 2023

Uh oh!

Devansu-Yadav commented Mar 21, 2023 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mustard-mh commented Mar 21, 2023 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Devansu-Yadav commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mustard-mh Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Devansu-Yadav Mar 25, 2023

Choose a reason for hiding this comment

Uh oh!

Devansu-Yadav Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gtsiolis Mar 30, 2023

Choose a reason for hiding this comment

Uh oh!

mustard-mh Mar 30, 2023

Choose a reason for hiding this comment

Uh oh!

gtsiolis Mar 30, 2023

Choose a reason for hiding this comment

Uh oh!

mustard-mh commented Mar 24, 2023 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

werft-gitpod-dev-com bot commented Mar 24, 2023

Uh oh!

gtsiolis commented Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Devansu-Yadav commented Apr 11, 2023

Uh oh!

gtsiolis commented Apr 11, 2023

Uh oh!

stale bot commented May 1, 2023

Uh oh!

Devansu-Yadav commented May 22, 2023

Uh oh!

gtsiolis commented May 22, 2023

Uh oh!

stale bot commented Jun 17, 2023

Uh oh!

akosyakov commented Jul 24, 2023

Uh oh!

gtsiolis commented Jul 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Devansu-Yadav commented Mar 21, 2023 •

edited by mustard-mh

Loading

Devansu-Yadav commented Mar 21, 2023 •

edited by werft-gitpod-dev-com bot

Loading

mustard-mh commented Mar 21, 2023 •

edited by werft-gitpod-dev-com bot

Loading

Devansu-Yadav commented Mar 23, 2023 •

edited

Loading

mustard-mh Mar 24, 2023 •

edited

Loading

Devansu-Yadav Mar 28, 2023 •

edited

Loading

mustard-mh commented Mar 24, 2023 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Mar 31, 2023 •

edited

Loading