Ensure workspace instances have a stoppingTime when they are stopped

[easyCZ]

In order to improve data quality of workspace instances, we need to ensure that all instances which are stopped (phasePersisted = 'stopped') also have a stoppingTime.

This is required to ensure that usage & billing remains accurate.

One can identify these cases in the DB with the following SQL query:

SELECT *
FROM d_b_workspace_instance
WHERE stoppingTime = '' AND phasePersisted = 'stopped'

There are 2 parts to this:

1. Ideally we want to fix the root-cause of this - identify where and under what conditions we fail to set the stoppingTime

2. Ensure that if it does happen, we automatically correct this scenario.

3. The WorkspaceInstance record is created and tracked by ws-manager-bridge when it receives updates from ws-manager (through bridge).

Note: There's currently a missing index (PR) on stoppingTime which makes it very slow to list all instances with stopping time not set.

Edit: Fixed type from stoppedTime to stoppingTime - these are different fields, but would make sense to keep them consistent anyway.

[geropl]

@easyCZ There is disconnect between the first paragraph "missing stoppedTime" and the query ("missing stoppingTime"). FWIW "missing stoppingTime" was originally considered a valid state. But would see your point in setting it anyhow. It's just that old data does not do it, and we'd need to think about back-filling it.

[easyCZ]

Correction: I mean stoppingTime in all cases in the above statement. I'll edit the issue as well.

[geropl]

FWIW:

• there also are DB entries without stoppedTime in the DB (3728) (query: SELECT * FROM d_b_workspace_instance WHERE stoppedTime = '' AND phasePersisted = 'stopped' ORDER BY creationTime DESC;)
• the underlying issue got fixed ~4 weeks ago with this commit
• there are three more recent entries, but those look like badly executed manual fixups 😢 Will fix those manually now.

[geropl]

Some of this has already been tackled by other recent PRs. Maybe we're already done here, but we should verify.

[laushinka]

Verified after querying the DB (SELECT * FROM d_b_workspace_instance WHERE stoppedTime = '' AND phasePersisted = 'stopped' ORDER BY creationTime DESC) that stopped workspace instances have a stopping time.