Gitpod prebuild is not running when PR created

[shaal]

Bug description

After configuring Gitpod Bot to run on all repositories

I added the prebuild section to .gitpod.yml
https://github.com/shaal/DrupalPod/blob/main/.gitpod.yml#L61

I created a PR shaal/DrupalPod#24

I see this comment in the PR

Clicking on this button - open Gitpod workspace with that PR, but skipping the prebuild process (and I see the whole process running in terminal)

Steps to reproduce

1. Find a repo that has init tasks
2. Configure Gitpod Bot to run on a repository
3. Make sure the prebuild section is in .gitpod.yml
4. Create a PR
5. Wait for the Bot to add "Open with Gitpod" button
6. Click on that button
7. Confirm Gitpod did not run prebuild and running Init tasks in terminal

Or

1. Create a new PR in https://github.com/shaal/DrupalPod/compare
2. Wait for the Bot to add "Open with Gitpod" button
3. Click on that button
4. Confirm Gitpod did not run prebuild and running Init tasks in terminal

Expected behavior

1. A new PR should trigger Gitpod prebuild.
2. The button "Open in Gitpod" appear as a PR comment, only after the prebuild process has finished.

Example repository

https://github.com/shaal/DrupalPod

Anything else?

No response

[shaal]

Perhaps this is related?
While working on this branch https://github.com/shaal/DrupalPod/tree/setup-modes, before a PR is created -

When I push changes, and open in a new tab - https://gitpod.io/#https://github.com/shaal/DrupalPod/tree/setup-modes -
I see the prebuild screen, which is what I expected to see. When the prebuild is done, the workspace is loaded with Gitpod interface, and I can see all the init commands running again in Terminal.

Only when I manually call for a prebuild of that branch - a "real" prebuild is run, and when the workspace opens, it is AFTER all init commands finished running, and the terminal only run command tasks.

[svenefftinge]

Hey Shaal,

I'm not sure I fully understand the issue here.
I just went to one of the latest PRs on the mentioned repo and started a workspace. I see lots of terminal output followed by

🤙 This task ran as a workspace prebuild
🎉 Well done on saving 3 minutes

So it looks like there is a prebuild. Is the issue resolved now or didn't I understand?

[shaal]

Hi @svenefftinge, the issue of prebuild is not resolved yet.
I feel some issues around prebuilds are a bit of a moving target...

The last comment I left here (#4925 (comment)) is the biggest problem I encountered (AFAIK @pawlean and @mikenikles experienced a similar issue).

TLDR:
When committing code, Gitpod automatically runs the "prebuild" process (which is good and work as expected)
BUT the problem is, that when the prebuild process is done, and Gitpod is starting a new workspace, it runs all the init commands as if the prebuild process did not run at all.

Here's a branch I created to test this,

• I forked the project
• I committed 1 dummy file
• I pushed the code back to repo.
• (Gitpod is running prebuild automatically)
• Workspace opens up, but now running all init tasks again, instead of using what was created during prebuild.

The way to "fix" it (and why you did not see it in DrupalPod, is because I manually ran https://gitpod.io/#prebuild/...).

Here's the example I created, and made sure NOT to run a manual prebuild -
https://gitpod.io/#https://github.com/shaal/DrupalPod/tree/automatic-prebuild-failing

[shaal]

EDIT: This is no longer fail as it used to 😲 which is... good? or perhaps it's more complex to replicate?
For now, all I can replicate is - after prebuild runs automatically, the page calls for a new workspace to open. THAT workspace runs the init tasks all over again. But closing that workspace and open a new one, is working better because it IS using the prebuild that ran automatically.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.