-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Labels
feature: docker in workspacesmeta: staleThis issue/PR is stale and will be closed soonThis issue/PR is stale and will be closed soonteam: workspaceIssue belongs to the Workspace teamIssue belongs to the Workspace team
Description
Is your feature request related to a problem? Please describe
We tried updating docker and disabling experimental for dockerd here.
We found that we could disable experimental on dockerd but not docker (it is enabled by default). We learned that Gitpod workspaces prefer the version of docker as specified by the workspace image, and docker-up's is only installed/used if not provided by the workspace image.
Describe the behaviour you'd like
Removed Experimental
- Review which dockerd features are experimental. Do we depend on any? If yes, leave experimental and create new issue to socialize removing experimental separate from this one.
- If we do not depend on them, proceed by removing the
experimentalargument for when we startdockerd. - Test to for breakage.
Update Docker version
- Update the version of docker used in docker-up
- Update the version of docker used in
workspace-imagestool-docker chunk. We likely need to trigger a rebuild. - Test in a workspace image that does NOT have docker preloaded, docker-up should install docker.
- Test in a workspace using
workspace-baseusing the timestamped image.
Describe alternatives you've considered
Continue running with experimental, but bump the version up in docker-up and workspace-images.
Metadata
Metadata
Assignees
Labels
feature: docker in workspacesmeta: staleThis issue/PR is stale and will be closed soonThis issue/PR is stale and will be closed soonteam: workspaceIssue belongs to the Workspace teamIssue belongs to the Workspace team