[usage] Establish database connection#10218
Merged
Merged
Conversation
roboquat
added
do-not-merge/work-in-progress
do-not-merge/release-note-label-needed
size/M
size/L
and removed
size/M
labels
andrew-farries
force-pushed
the
mp/db-conn
branch
from
e83e565 to
868f788
Compare
easyCZ
force-pushed
the
mp/db-conn
branch
2 times, most recently
from
f574719 to
dd421f6
Compare
easyCZ
changed the title
geropl
reviewed
May 30, 2022
geropl
approved these changes
May 30, 2022
Member
geropl
left a comment
geropl
left a comment
There was a problem hiding this comment.
Code LGTM, tested and works ✔️
Co-authored-by: Gero Posmyk-Leinemann <32448529+geropl@users.noreply.github.com>
roboquat
added
deployed: webapp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initial setup to establish a database connection. This PR ensures that we can run tests against a DB both in a workspace, or in CI.
Related Issue(s)
Fixes #
How to test
cd components/usage && go test ./...This will prompt you to run
leeway components/usage:init-testdbto start the serverThen running above again, will result in tests passing.
This setup is already done in CI and mirrors how we run tests against
gitpod-dbcomponent.Release Notes
Documentation
NONE