Update ssh gw dashboard#10693
Merged
Merged
Conversation
|
started the job as gitpod-build-ak-ssh-gw-dashboard.1 because the annotations in the pull request description changed |
Member
Author
|
@iQQBot could you review whether it is alright with you? |
iQQBot
reviewed
Jun 16, 2022
iQQBot
approved these changes
Jun 16, 2022
Contributor
iQQBot
left a comment
There was a problem hiding this comment.
LGTM, I think you can also remove this part
https://github.com/gitpod-io/gitpod/pull/10693/files#diff-8d4ba5399468d59d11fcfe4769266e5054d8c6d7a098d5961c5ffbb96c94427bR428-R453
/hold
Member
Author
Unfortunately link does not highlight lines. Maybe you can comment on the file? |
Contributor
|
|
Simplify it to show most important info: - throughput of valid and suspicious traffic - total failure ratios and error ratios by kind
Member
Author
|
@iQQBot makes sense, updated and pushed 🙏 |
7930e9b to
56f62ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Simplify it to show most important info:
Related Issue(s)
Fixes #
How to test
See https://grafana.gitpod.io/d/anton-ssh/antons-ssh-gateway-overview?orgId=1&refresh=30s
Release Notes
Documentation