call prestophook.sh from ring1 directly#10776
Merged
Merged
Conversation
|
started the job as gitpod-build-pavel-10260-hook.1 because the annotations in the pull request description changed |
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
Contributor
I didn't have a admin permission 😭 |
jenting
approved these changes
Jun 21, 2022
roboquat
added
deployed: workspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When adding support for prebuilds to work with PVC, noticed that pod's lifecycle hook does not execute for prebuilds, because when they are done, they transition into completed state.
So this PR changes how prestophook.sh is executed and allows prebuilds to execute it as well now.
Related Issue(s)
Related to #10689
How to test
Release Notes
Documentation
Werft options: