[usage] Batch list workspace instances in range#10789
Merged
Merged
Conversation
easyCZ
force-pushed
the
mp/usage-batch-wsi
branch
2 times, most recently
from
fb3558b to
0a73a23
Compare
| Where("creationTime < ?", TimeToISO8601(to)). | ||
| Where("startedTime != ?", ""). | ||
| Find(&instances) | ||
| FindInBatches(&instancesInBatch, 1000, func(tx *gorm.DB, batch int) error { |
Contributor
There was a problem hiding this comment.
What's the batch parameter intended to be used for? If it's not used can we replace it with _ ?
Member
Author
There was a problem hiding this comment.
https://gorm.io/docs/advanced_query.html#FindInBatches
Will make it unused.
|
|
||
| } | ||
|
|
||
| tx := conn.CreateInBatches(&instances, 1000) |
Contributor
There was a problem hiding this comment.
Why do we need to CreateInBatches here?
Member
Author
There was a problem hiding this comment.
We don't strictly, but felt like I should start a pattern of not doing things with more than 1k entries outside batches
easyCZ
force-pushed
the
mp/usage-batch-wsi
branch
from
0a73a23 to
febbad0
Compare
Contributor
|
/werft run 👍 started the job as gitpod-build-mp-usage-batch-wsi.4 |
easyCZ
commented
Jun 21, 2022
| } | ||
|
|
||
| workspaceID := generateWorkspaceID() | ||
| workspaceID := GenerateWorkspaceID() |
Member
Author
There was a problem hiding this comment.
This also fixes broken master due to a semantic merge.
andrew-farries
approved these changes
Jun 21, 2022
roboquat
added
deployed: webapp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lists Workspace Instances in batches of 100
Related Issue(s)
Fixes #
How to test
Unit tests
Release Notes
Documentation
NONE