Skip to content

Conversation

@mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Oct 21, 2022

Description

Related Issue(s)

How to test

  • Switch to VS Code Browser Insiders in settings.
  • Start a workspace.
  • Test the following:
    • terminals are preserved and resized properly between window reloads
    • WebViews are working
    • extension host process: check language smartness and debugging
    • extension management (installing/uninstalling)
    • install the VIM extension to test web extensions
    • that user data is synced across workspaces as well as on workspace restarts, especially for extensions
      • extensions from .gitpod.yml are not installed as sync
      • extensions installed as sync are actually synced to all new workspaces
    • settings should not contain any mentions of MS telemetry
    • WebSockets and workers are properly proxied
      • diff editor should be operatable
      • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old WebSockets are closed and new opened of the same amount
    • workspace specific commands should work, i.e. F1 → type Gitpod prefix
    • that a PR view is preloaded when opening a PR URL
    • test gp open and gp preview
    • test open in VS Code Desktop, check gp open and gp preview in task/user terminals
    • telemetry data is collected in Segment

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-vs-build.6 because the annotations in the pull request description changed
(with .werft/ from main)

@mustard-mh
Copy link
Contributor Author

/hold

To test first

@mustard-mh
Copy link
Contributor Author

mustard-mh commented Oct 21, 2022

@filiptronicek Could you approve this PR? I'll test it after werft build succeeds, and then unhold it 🙏

@filiptronicek
Copy link
Member

filiptronicek commented Oct 21, 2022

@mustard-mh you got it! Thanks for taking over this patch release, I was waiting for Microsoft to release (thought they might add more changes to the release branch), but it doesn't seem like they will and it seems more that they forgot to create a release 😆.

@mustard-mh
Copy link
Contributor Author

mustard-mh commented Oct 21, 2022

/unhold

Works 🎉
image

@roboquat roboquat merged commit 89db639 into main Oct 21, 2022
@roboquat roboquat deleted the hw/vs-build branch October 21, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants