polish IDEFrontendDashboardService #15895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-ak-frontend-pollish.1 because the annotations in the pull request description changed |
akosyakov
force-pushed
the
ak/frontend_pollish
branch
from
d88914f to
f8fd567
Compare
- add docs and security notes - remove imlementation methods from the interface - fix a regression with opening desktop IDEs on the workspace origin - allow to access the interface from other locations for the same workspace, i.e. for dev and debug modes
akosyakov
force-pushed
the
ak/frontend_pollish
branch
from
f8fd567 to
2534691
Compare
github-actions
bot
added
team: IDE
team: webapp
jeanp413
approved these changes
Jan 19, 2023
andrew-farries
approved these changes
Jan 20, 2023
Contributor
andrew-farries
left a comment
andrew-farries
left a comment
There was a problem hiding this comment.
👍 Added hold for a couple of questions. Feel free to remove.
| title: "Open in Browser", | ||
| onClick: () => window.parent.postMessage({ type: "openBrowserIde" }, "*"), | ||
| onClick: () => { | ||
| // TODO(ak): delete after supervisor deploy |
Contributor
There was a problem hiding this comment.
Is this TODO intended to be left in place?
Member
Author
There was a problem hiding this comment.
after both deployments, we will do another PR to clean up
| return; | ||
| } | ||
|
|
||
| // TODO(ak) remove after new dashboard is deployed |
Contributor
There was a problem hiding this comment.
Same question about the todo
Member
Author
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes are backward compatible and does not require coordinated deployment. But a follow up clean up PR is required after both supervisor and dashboard are deployed.
Related Issue(s)
Fixes #
How to test
Start a workspace with IntelliJ IDEA, check that you can open VS Code Browser and IntelliJ IDEA. While redirection got IntelliJ the origin should be gitpod, not workspace.
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh