Fix inconsistent autostart data on ws creation #19581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes, if you had a preferred workspace class saved, this preference wouldn't be applied when creating a new workspace. Instead, the system would revert to the default setting. The root cause of this issue was that the code didn't properly wait for the query fetching the allowed workspace classes to finish. As a result, when it tried to verify if your saved preference was permitted according to the allowlist, it found the list to be empty, leading to the default setting being applied.
Related Issue(s)
Fixes EXP-1502
How to test
/public-api/gitpod.v1.OrganizationService/GetOrganizationSettingsand/public-api/gitpod.v1.WorkspaceService/ListWorkspaceClassesDocumentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold