Skip to content

Conversation

@filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Mar 27, 2024

Description

Sometimes, if you had a preferred workspace class saved, this preference wouldn't be applied when creating a new workspace. Instead, the system would revert to the default setting. The root cause of this issue was that the code didn't properly wait for the query fetching the allowed workspace classes to finish. As a result, when it tried to verify if your saved preference was permitted according to the allowlist, it found the list to be empty, leading to the default setting being applied.

Related Issue(s)

Fixes EXP-1502

How to test

  1. Start a workspace with context URL A on a non-default workspace class
  2. Block /public-api/gitpod.v1.OrganizationService/GetOrganizationSettings and /public-api/gitpod.v1.WorkspaceService/ListWorkspaceClasses
  3. Clear the indexed db so that the caches are not used (can be done in the devtools)
  4. Open the create workspace page with the context URL A again
  5. Wait until the first requests to the above method fail and unblock them
  6. Observe that even after recovering from the blocked requests, the UI shows the previously stored class.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@roboquat roboquat added size/S and removed size/XS labels Mar 27, 2024
@filiptronicek filiptronicek changed the title Fix broken autostart data on ws creation Fix inconsistent autostart data on ws creation Mar 27, 2024
@filiptronicek filiptronicek marked this pull request as ready for review March 27, 2024 14:58
@filiptronicek filiptronicek requested a review from a team as a code owner March 27, 2024 14:58
@filiptronicek filiptronicek self-assigned this Mar 27, 2024
@roboquat roboquat merged commit 0e2a44c into main Mar 27, 2024
@roboquat roboquat deleted the ft/fix-autostart-races branch March 27, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants