[previewctl] Add error logging in install-context command #21247
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
previewctl install-contextfails, the error message only showsexit status 1without any context about what went wrong:Root Cause
The failure happens before any logging occurs, likely in
PreRunEwhen generating the SSH key. TheGenerateSSHPrivateKey()function:/github/home/.ssh/)cmd.Run()which discards all output, sossh-keygenfailures are silentSolution
1. Fix SSH key generation (
preview.go)os.MkdirAll()before runningssh-keygenssh-keygenoutput in error messages2. Add error logging in install function (
install_context.go)failed to get preview namefailed to create preview configfailed to install contextThis complements PR #21246 which added error logging in
installVMSSHKeys().