devcontainer: download pup binary instead of go install#21360
Merged
Conversation
pup v0.4.0 (2017) fails to compile with modern Go versions. Download the pre-built binary from GitHub releases instead, matching the approach already used in dev/image/Dockerfile. Co-authored-by: Ona <no-reply@ona.com>
corneliusludmann
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pupv0.4.0 (released 2017) fails to compile with modern Go versions, breaking the devcontainer image build. This replacesgo install github.com/ericchiang/pup@v0.4.0with a direct download of the pre-built binary from GitHub releases.This matches the approach already used in
dev/image/Dockerfileand supports multi-arch builds viaTARGETARCH.Related Issue(s)
Fixes CORE-
How to test
pupis available:which pup && pup --version