Merged
Conversation
The REH server COPY overlays /vscode-reh-linux-x64/ onto /vscode-web/ in /ide/, overwriting the web client's NLS files with the REH server's version. Normal workspaces are unaffected because blobserve reads only the first Docker layer. Debug workspaces serve from the merged filesystem, causing workbench.js to reference NLS indices that don't exist in the REH's nls.messages.js. Restore the web client NLS files after the REH overlay. Co-authored-by: Ona <no-reply@ona.com>
Contributor
Author
Contributor
Author
Contributor
Author
|
I had to do the setup like so for the preview: And then start a new environment, and test |
mustard-mh
reviewed
Mar 27, 2026
mustard-mh
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Debug workspaces created via
gp validatethrow!!! NLS MISSING: 1837 !!!in the browser console, breaking UI components.The IDE Docker image copies
/vscode-web/then/vscode-reh-linux-x64/into/ide/. The REH overlay overwrites the web client's NLS files (nls.messages.js, etc.) with the REH server's version, which has different message counts and index ordering.Normal workspaces are unaffected because blobserve reads only the first Docker layer (the web client). Debug workspaces serve from the merged
/ide/filesystem, soworkbench.jsreferences NLS indices that don't exist in the REH'snls.messages.js.This became a problem after #21350 changed the build pipeline from
compile-build-without-mangling(shared NLS state) tocore-ci(separate builds with divergent NLS outputs).Fix: restore the four web client NLS files after the REH overlay.
Related Issue(s)
Fixes CLC-2237
How to test
gp validateNLS MISSINGerrors in the browser consoleDocumentation
No docs changes needed.
/hold