[vscode] support port preview #3432
Conversation
|
fixes #3382 |
akosyakov
force-pushed
the
akosyakov/code-support-embedded-2806
branch
from
11996d7 to
66d33e9
Compare
| if err == theialib.ErrNotFound { | ||
| gpPreviewBrowser := os.Getenv("GP_PREVIEW_BROWSER") | ||
| if gpPreviewBrowser != "" { | ||
| gpPreviewArgs := strings.Fields(gpPreviewBrowser) |
There was a problem hiding this comment.
@csweichel Does it look correct to support command with args? We probably should the same for GP_OPEN_EDITOR otherwise exec.LookPath will fail
There was a problem hiding this comment.
Indeed, we should do that for GP_OPEN_EDITOR as well.
I'd be happy to do this in a follow-up PR.
akosyakov
requested review from
JanKoehnlein,
csweichel,
jankeromnes and
svenefftinge
|
/werft run 👍 started the job as gitpod-build-akosyakov-code-support-embedded-2806.3 |
svenefftinge
left a comment
svenefftinge
left a comment
There was a problem hiding this comment.
Works nicely and LGTM
akosyakov
force-pushed
the
akosyakov/code-support-embedded-2806
branch
from
66d33e9 to
41ff7d2
Compare
akosyakov
force-pushed
the
akosyakov/code-support-embedded-2806
branch
from
41ff7d2 to
b5b0a7c
Compare
|
Nice. Is this currently testable in production? I see it has been merged to main. outputs: |
|
No, it’s not yet in prod. But We are releasing next Tuesday with lots of improvements.
… Am 31.03.2021 um 20:37 schrieb Apolo Pena ***@***.***>:
Nice. Is this currently testable in production? I see it has been merged to main.
When I have apache running on port 8001, this:
gp preview $(gp url 8001)
outputs
2021/03/31 18:36:25 not found
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Cool, thanks for the update. Is there an easy way to tell when code has been merged to main but not pushed to production? Or do I need to trace the trail of issues to a milestone? |
|
You can check whether the milestone is closed, if not we are still working on it. As soon as we ship we close the milestone: https://github.com/gitpod-io/gitpod/milestones |
What it does
gp previewChanges in VS Code: gitpod-io/openvscode-server@845053f...f75d023
How to test
curl lama.sh | LAMA_PORT=9090 shand check that notification pops up with working preview buttongp preview https://localhost:9090andgp preview $(gp url 9090)both should work by opening an external port URL, not localhost!