Skip to content

Conversation

@geropl
Copy link
Member

@geropl geropl commented Dec 17, 2021

Description

This removes the PrebuildStatusMaintainer (and, in a follow-up PR, the table d_b_prebuild_workspace_updatable). The only use case this code served was that it added a "prebuild status badge" to PRs. But this functionality has not been exposed for a very long time, and thus was not used anymore.

TODO:

  • after this is deployed: Create a PR to actually remove the table

Related Issue(s)

Fixes #7436

How to test

Release Notes

NONE

Documentation

@stale
Copy link

stale bot commented Dec 28, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Dec 28, 2021
@stale stale bot closed this Jan 2, 2022
@geropl geropl reopened this Jan 4, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Jan 4, 2022
geropl added 2 commits January 5, 2022 15:36
We can remove this without prior deprecationg because it has never been part of the externak interface (gitpod-schema.json)
@geropl
Copy link
Member Author

geropl commented Jan 5, 2022

/werft with-clean-slate-deployment

👎 unknown command: with-clean-slate-deployment
Use /werft help to list the available commands

@geropl
Copy link
Member Author

geropl commented Jan 5, 2022

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-gpl-cleanup.4

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #7284 (a62ce4a) into main (7538206) will decrease coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7284      +/-   ##
==========================================
- Coverage   29.72%   29.19%   -0.54%     
==========================================
  Files          60       57       -3     
  Lines        8911     8040     -871     
==========================================
- Hits         2649     2347     -302     
+ Misses       6060     5521     -539     
+ Partials      202      172      -30     
Flag Coverage Δ
components-ee-agent-smith-app 40.32% <ø> (ø)
components-ee-agent-smith-lib 40.05% <ø> (-0.28%) ⬇️
components-gitpod-cli-app 9.56% <ø> (ø)
components-gitpod-protocol-go-lib ∅ <ø> (∅)
components-ide-code-desktop-status-app ?
components-image-builder-mk3-app ?
components-local-app-api-go-lib ?
components-local-app-app-darwin-amd64 ∅ <ø> (∅)
components-local-app-app-darwin-arm64 ∅ <ø> (∅)
components-local-app-app-linux-amd64 19.04% <ø> (ø)
components-local-app-app-linux-arm64 ∅ <ø> (∅)
components-local-app-app-windows-386 ∅ <ø> (∅)
components-local-app-app-windows-amd64 ∅ <ø> (∅)
components-local-app-app-windows-arm64 ∅ <ø> (∅)
components-supervisor-api-go-lib ?
components-supervisor-app 37.14% <ø> (+0.11%) ⬆️
installer-raw-app 5.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/ports/ports.go 61.37% <0.00%> (-0.09%) ⬇️
...ents/image-builder-mk3/pkg/orchestrator/monitor.go
...ents/image-builder-mk3/pkg/orchestrator/metrics.go
...image-builder-mk3/pkg/orchestrator/orchestrator.go
components/supervisor/pkg/supervisor/supervisor.go 5.98% <0.00%> (+0.02%) ⬆️
components/supervisor/pkg/terminal/terminal.go 64.83% <0.00%> (+0.91%) ⬆️
components/supervisor/pkg/config/gitpod-config.go 79.46% <0.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c61a7...a62ce4a. Read the comment docs.

@geropl geropl changed the title [server, et al] Remove PrebuildStatusMaintainer and subsequent unused… [server, et al] Remove PrebuildStatusMaintainer and subsequent unused code Jan 5, 2022
@geropl geropl marked this pull request as ready for review January 5, 2022 16:39
@geropl geropl requested a review from a team January 5, 2022 16:39
@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Jan 7, 2022

LGTM label has been added.

Git tree hash: 28df00db9e955b606e08b1fe9e29841320f40087

@roboquat
Copy link
Contributor

roboquat commented Jan 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #7436

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 63aba9a into main Jan 7, 2022
@roboquat roboquat deleted the gpl/cleanup branch January 7, 2022 14:05
@csweichel
Copy link
Contributor

csweichel commented Jan 10, 2022

IMHO this PR also removed the status check update mechanism, not just the badges 😱

@svenefftinge
Copy link
Contributor

Seems like this was on purpose?

Note that this comes with a minor feature removal: We no longer push prebuild-statuus to GitHub commits. (reference)

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XXL team: webapp Issue belongs to the WebApp team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Remove PrebuildStatusMaintainer (last non-local writer to messagebus besides ws-manager-bridge)

5 participants