-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[server, et al] Remove PrebuildStatusMaintainer and subsequent unused code #7284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
We can remove this without prior deprecationg because it has never been part of the externak interface (gitpod-schema.json)
|
/werft with-clean-slate-deployment 👎 unknown command: with-clean-slate-deployment |
|
/werft run with-clean-slate-deployment 👍 started the job as gitpod-build-gpl-cleanup.4 |
Codecov Report
@@ Coverage Diff @@
## main #7284 +/- ##
==========================================
- Coverage 29.72% 29.19% -0.54%
==========================================
Files 60 57 -3
Lines 8911 8040 -871
==========================================
- Hits 2649 2347 -302
+ Misses 6060 5521 -539
+ Partials 202 172 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/lgtm |
|
LGTM label has been added. Git tree hash: 28df00db9e955b606e08b1fe9e29841320f40087
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JanKoehnlein Associated issue: #7436 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
IMHO this PR also removed the status check update mechanism, not just the badges 😱 |
|
Seems like this was on purpose?
|
Description
This removes the
PrebuildStatusMaintainer(and, in a follow-up PR, the tabled_b_prebuild_workspace_updatable). The only use case this code served was that it added a "prebuild status badge" to PRs. But this functionality has not been exposed for a very long time, and thus was not used anymore.TODO:
Related Issue(s)
Fixes #7436
How to test
Release Notes
Documentation