Skip to content

Conversation

@geropl
Copy link
Member

@geropl geropl commented Jan 10, 2022

Description

Reverts PR #7284.

We learned that we indeed use that code. There is room for improvement, but to unblock other work, we go with revert first.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

@roboquat roboquat added release-note-none team: webapp Issue belongs to the WebApp team size/XXL labels Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #7522 (9ddf14b) into main (aa47428) will decrease coverage by 0.79%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #7522      +/-   ##
========================================
- Coverage   8.38%   7.58%   -0.80%     
========================================
  Files         33      31       -2     
  Lines       2410    2242     -168     
========================================
- Hits         202     170      -32     
+ Misses      2204    2070     -134     
+ Partials       4       2       -2     
Flag Coverage Δ
components-gitpod-cli-app 9.53% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa47428...9ddf14b. Read the comment docs.

@geropl geropl requested a review from a team January 10, 2022 13:09
@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: cef0dd8a6a306787011efd4bdae63c074c2fc489

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #7284

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 28597c5 into main Jan 10, 2022
@roboquat roboquat deleted the gpl/revert-7284 branch January 10, 2022 15:02
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XXL team: webapp Issue belongs to the WebApp team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants