Skip to content

Fix overflow on port not found page#8121

Merged
roboquat merged 1 commit intogitpod-io:mainfrom
krystxf:fix/port-not-found-overflow
Feb 10, 2022
Merged

Fix overflow on port not found page#8121
roboquat merged 1 commit intogitpod-io:mainfrom
krystxf:fix/port-not-found-overflow

Conversation

@krystxf
Copy link
Copy Markdown
Contributor

@krystxf krystxf commented Feb 9, 2022

Description

Fixed Y overflow on port not found page

How to test

Open a port on which nothing is running.

Release Notes

NONE

Documentation

@krystxf
Copy link
Copy Markdown
Contributor Author

krystxf commented Feb 9, 2022

Before:

image

After:

image
Activate Windows alert not included

@sagor999 sagor999 requested a review from a team February 9, 2022 16:56
@princerachit
Copy link
Copy Markdown
Contributor

princerachit commented Feb 10, 2022

/werft run

👍 started the job as gitpod-build-fix-port-not-found-overflow-fork.0

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 10, 2022

Codecov Report

Merging #8121 (0e169dd) into main (e0f7bfe) will increase coverage by 16.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8121       +/-   ##
===========================================
+ Coverage   11.98%   28.36%   +16.37%     
===========================================
  Files          20       39       +19     
  Lines        1193     3342     +2149     
===========================================
+ Hits          143      948      +805     
- Misses       1046     2341     +1295     
- Partials        4       53       +49     
Flag Coverage Δ
components-gitpod-cli-app 10.82% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-proxy-app 68.32% <ø> (?)
installer-raw-app 5.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/ws-proxy/pkg/proxy/workspacerouter.go 81.89% <0.00%> (ø)
...components/ws-manager/unpriviledged-rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/configmap.go 30.05% <0.00%> (ø)
installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
components/ws-proxy/pkg/proxy/infoprovider.go 4.90% <0.00%> (ø)
installer/pkg/components/ws-manager/tlssecret.go 0.00% <0.00%> (ø)
components/ws-proxy/pkg/proxy/auth.go 100.00% <0.00%> (ø)
installer/pkg/common/render.go 0.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f7bfe...0e169dd. Read the comment docs.

@princerachit
Copy link
Copy Markdown
Contributor

/approve no-issue

@roboquat roboquat merged commit ededf2c into gitpod-io:main Feb 10, 2022
@princerachit
Copy link
Copy Markdown
Contributor

Thanks for the PR @krystofex krystofex

@krystxf
Copy link
Copy Markdown
Contributor Author

krystxf commented Feb 10, 2022

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants