[installer]: add explanation for configuring AWS container registry#8322
Merged
Conversation
7851a54 to
8d7c72f
Compare
Codecov Report
@@ Coverage Diff @@
## main #8322 +/- ##
==========================================
- Coverage 33.00% 7.60% -25.41%
==========================================
Files 33 31 -2
Lines 4735 2171 -2564
==========================================
- Hits 1563 165 -1398
+ Misses 3054 2003 -1051
+ Partials 118 3 -115
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
8d7c72f to
2d45bc6
Compare
2d45bc6 to
c13d761
Compare
corneliusludmann
approved these changes
Feb 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a note of clarification on how to use AWS ECR as push registry. Thanks to @eiymba for asking the question
As was in this section, I've added some validation on the secret
Related Issue(s)
Fixes #8321
How to test
Release Notes
Documentation