[ws-manager] fix incorrect status when image pull is done#8335
Merged
Conversation
3427660 to
d056d6a
Compare
Codecov Report
@@ Coverage Diff @@
## main #8335 +/- ##
===========================================
+ Coverage 12.31% 33.40% +21.08%
===========================================
Files 20 31 +11
Lines 1161 4559 +3398
===========================================
+ Hits 143 1523 +1380
- Misses 1014 2920 +1906
- Partials 4 116 +112
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
csweichel
approved these changes
Feb 21, 2022
Contributor
csweichel
left a comment
There was a problem hiding this comment.
This change makes sense. It's mostly a left-over from the days when content init wasn't tied to container readiness.
Great find!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[ws-manager] fix incorrect status when image pull is done
If
podis running, the workspace status should be change toinitializingRelated Issue(s)
Fixes #8323
How to test
ddinitializinginstead ofpulling imageRelease Notes
Documentation