[installer] Tidy up omitempty in config#8436
Merged
Merged
Conversation
/werft no-preview
Codecov Report
@@ Coverage Diff @@
## main #8436 +/- ##
========================================
- Coverage 8.41% 7.59% -0.83%
========================================
Files 33 31 -2
Lines 2340 2172 -168
========================================
- Hits 197 165 -32
+ Misses 2138 2004 -134
+ Partials 5 3 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
github-actions
Bot
added
the
team: delivery
mrsimonemms
approved these changes
Feb 24, 2022
Contributor
mrsimonemms
left a comment
mrsimonemms
left a comment
There was a problem hiding this comment.
Omitempty is my friend - terser config is good config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change is a tidy-up of what is generated with
installer init. It ...disableDefinitelyGpomitemptyfor values that arenullby default (be more consistent, alternative: removeomitemtpymore or less everywhere and render allnullvalues)example-config.yamlfileHow to test
Nothing to do, just look at the updated
example-config.yamlfile and express your feelings about this change.Release Notes
Meta
/werft no-preview