Skip to content

[dashboard] it makes more sense to have the green reflect the "remaining hours" instead of "cosumed". Having the "consumed" it creates confusion. see issue 9702 #9716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ionutale wants to merge 2 commits into from
Closed

[dashboard] it makes more sense to have the green reflect the "remaining hours" instead of "cosumed". Having the "consumed" it creates confusion. see issue 9702 #9716

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18cc1fa
[dashboard] it makes more sense to have the green reflect the "remain…
ionutale May 3, 2022
575c947
Merge branch 'gitpod-io:main' into plan-remaining-hours-and-9702
ionutale Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions components/dashboard/src/settings/Plans.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,10 +669,7 @@ export default function () {
</Tooltip>
{typeof accountStatement?.remainingHours === "number" &&
typeof currentPlan.hoursPerMonth === "number" ? (
<progress
value={currentPlan.hoursPerMonth - accountStatement.remainingHours}
max={currentPlan.hoursPerMonth}
/>
<progress value={accountStatement.remainingHours} max={currentPlan.hoursPerMonth} />
Copy link
Contributor

@gtsiolis gtsiolis May 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I was thinking we could a) make this more useful for the upcoming usage-based pricing, b) keep the existing approach, c) add some clarity to the copy, d) avoid the negative aspects that could be attached with the draining hours progress, e) improve accessibility on this area with removing the tooltip used here by making this look like the following:

BEFORE AFTER
usage-before usage-after

What do you think? Cc @jankeromnes since we've worked together in the initial implementation in #3550.

) : (
<progress value="0" max="100" />
)}
Expand Down