Skip to content

fix: skip vulnerability scanning for packages that failed to build #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leodido merged 1 commit into from
Dec 3, 2025
Merged

fix: skip vulnerability scanning for packages that failed to build #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/leeway/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,8 +748,10 @@ func Build(pkg *Package, opts ...BuildOption) (err error) {

// Scan all packages for vulnerabilities after the build completes
// This ensures we scan even cached packages that weren't rebuilt
// Only scan packages that were successfully built or downloaded to avoid
// errors when a dependency build failed in a parallel goroutine
if pkg.C.W.SBOM.Enabled && pkg.C.W.SBOM.ScanVulnerabilities {
if err := scanAllPackagesForVulnerabilities(ctx, allpkg); err != nil {
if err := scanAllPackagesForVulnerabilities(ctx, allpkg, pkgstatus); err != nil {
return err
}
}
Expand Down
33 changes: 28 additions & 5 deletions pkg/leeway/sbom-scan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ type PackageVulnerabilityStats struct {
// This function is called after the build process completes to identify security issues
// in all built packages, including those loaded from cache. It generates comprehensive
// vulnerability reports in multiple formats and collects statistics across all packages.
func scanAllPackagesForVulnerabilities(buildctx *buildContext, packages []*Package, customOutputDir ...string) error {
//
// Only packages with successful build status (PackageBuilt or PackageDownloaded) are scanned.
// This prevents errors when a dependency build fails in a parallel goroutine but the main
// build continues (due to the build lock mechanism allowing other goroutines to proceed).
func scanAllPackagesForVulnerabilities(buildctx *buildContext, packages []*Package, pkgstatus map[*Package]PackageBuildStatus, customOutputDir ...string) error {
if len(packages) == 0 {
return nil
}
Expand All @@ -74,6 +78,15 @@ func scanAllPackagesForVulnerabilities(buildctx *buildContext, packages []*Packa

// Process each package
for _, p := range packages {
// Skip packages that were not successfully built or downloaded
// This can happen when a dependency build fails in a parallel goroutine
// but other goroutines continue due to the build lock mechanism
status := pkgstatus[p]
if status != PackageBuilt && status != PackageDownloaded {
buildctx.Reporter.PackageBuildLog(p, false, []byte(fmt.Sprintf("Skipping vulnerability scan for package %s (status: %s)\n", p.FullName(), status)))
continue
}

if !p.C.W.SBOM.Enabled {
errMsg := fmt.Append(nil, "SBOM feature is disabled, cannot scan for vulnerabilities")
buildctx.Reporter.PackageBuildLog(p, false, errMsg)
Expand All @@ -88,9 +101,10 @@ func scanAllPackagesForVulnerabilities(buildctx *buildContext, packages []*Packa

location, exists := buildctx.LocalCache.Location(p)
if !exists {
errMsg := fmt.Appendf(nil, "Package %s not found in local cache, cannot scan for vulnerabilities\n", p.FullName())
buildctx.Reporter.PackageBuildLog(p, false, errMsg)
return xerrors.Errorf(string(errMsg))
// This should not happen since we already filtered by build status,
// but handle it gracefully just in case
buildctx.Reporter.PackageBuildLog(p, false, []byte(fmt.Sprintf("Package %s not found in local cache, skipping vulnerability scan\n", p.FullName())))
continue
}

// Create temporary file for SBOM content
Expand Down Expand Up @@ -194,6 +208,8 @@ func scanAllPackagesForVulnerabilities(buildctx *buildContext, packages []*Packa
// ScanAllPackagesForVulnerabilities provides a public API for scanning packages for vulnerabilities.
// It creates a build context with the provided local cache and reporter, then calls the internal
// scanAllPackagesForVulnerabilities function to perform the actual scanning.
//
// This function assumes all provided packages are already built and available in the local cache.
func ScanAllPackagesForVulnerabilities(localCache cache.LocalCache, packages []*Package, customOutputDir ...string) error {
buildctx := &buildContext{
buildOptions: buildOptions{
Expand All @@ -202,7 +218,14 @@ func ScanAllPackagesForVulnerabilities(localCache cache.LocalCache, packages []*
},
}

return scanAllPackagesForVulnerabilities(buildctx, packages, customOutputDir...)
// Create a status map marking all packages as built (since this is a public API
// that expects packages to already be in cache)
pkgstatus := make(map[*Package]PackageBuildStatus)
for _, p := range packages {
pkgstatus[p] = PackageBuilt
}

return scanAllPackagesForVulnerabilities(buildctx, packages, pkgstatus, customOutputDir...)
}

// scanSBOMForVulnerabilities scans an SBOM file for vulnerabilities and generates reports.
Expand Down
Loading