fix: add -trimpath to default Go build command #312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
-trimpathflag to the default Go build command for reproducible builds.Part of https://linear.app/ona-team/issue/CLC-2085/fix-leeway-slsa-verification-to-enable-remote-cache
Stacked on #311
Problem
Without
-trimpath, Go embeds absolute file paths in the binary. These paths vary between build machines (e.g.,/home/user1/projectvs/home/user2/project), causing identical source code to produce different binaries.Solution
Add
-trimpathto the default build command when no custombuildCommandis specified:Impact
buildCommandare unaffected (they should already include-trimpathif reproducibility is needed)-trimpathonly affects debug info paths, not runtime behaviorTesting
-trimpathis included in default build command