fix: health endpoint uses machine-readable reason field for env guard (#36)#43
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
✅ UI verification skipped — no UI files changed (no |
Collaborator
Author
|
✅ Post-merge verification passed. Routes tested:
Skipped: none Console errors: none |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36
Supersedes #41 (rebased cleanly onto current main to resolve merge conflicts).
What
Changes the health endpoint's env var guard response from
message: "not configured"toreason: "not_configured"— a machine-readable snake_case value suitable for programmatic consumption.Changes
src/app/api/health/route.ts:db.message→db.reasonwith"not_configured"value, added explanatory commentsrc/app/api/health/route.test.ts: Updated assertions to match new field name.agents/conventions.md: Added env var guard to API route code example, added "Guarding Supabase env vars" subsection documenting the patternTesting
All 8 tests pass:
pnpm lint && pnpm typecheck && pnpm test