feat(user): split repositories list by type #739
Conversation
machour
left a comment
machour
left a comment
There was a problem hiding this comment.
This is great @Arjun-sna !
I left you some remarks, my biggest concern being that the button group won't play nice with longer texts when using translations .. not really sure how to properly handle it :/
| 'user.repositoryList.memberReposButton', | ||
| locale | ||
| ), | ||
| ] |
There was a problem hiding this comment.
Could this be computed outside the JSX and condensed?
const buttons = ['common','buttons'];
if (authUser.login === currentuser.login) {
buttons.push('other');
buttons.push('buttons');
}
| headerRight: ( | ||
| <Icon | ||
| name="search" | ||
| color={colors.primaryDark} |
There was a problem hiding this comment.
personal taste: maybe greyDark would be better (in find the loop "too black")
| </SearchContainer> | ||
| </SearchBarWrapper> | ||
| ) : ( | ||
| <StyledButtonGroup |
There was a problem hiding this comment.
English labels fits right in, but I'm afraid other translations won't play as nice.. 🤔
Try with french labels for example: "Tous, Propriétaire, Membre, Privé, Public"
machour
changed the title
|
(In order to fix the Travis build, you have to add the english sentences in all the translations files. |
add default texts for repo type titles for other languages
|
@machour tried to fix longer texts with |
3 participants
Screenshots Auth user
Screenshots user
Description
Added categories to repo list screen