Skip to content

Conversation

@NHanser
Copy link
Contributor

@NHanser NHanser commented Jan 9, 2022

Use NUL character instead of semicolon to extract meta and path. Avoid errors in during git diff when dealing with filenames containing semicolons
Re-submit (#1387 (comment))

Use NUL character instead of semicolon to extract meta and path. Avoid errors in during git diff when dealing with filenames containing semicolons
@NHanser NHanser closed this Jan 9, 2022
@NHanser
Copy link
Contributor Author

NHanser commented Jan 9, 2022

Test not passed. Need to review why (only valid with raw? I'm using diff with this option if I remember (don't have code with me))

@Byron
Copy link
Member

Byron commented Jan 9, 2022

Thanks for giving it another look. By the way, it's possible to turn on actions in your own fork which then should run them each time you push into a branch even, no PR to check CI is needed then.

I also don't mind to keep this PR open and let it re-run each time there is a change to see if that worked and in case it's not reproducible locally - I'd think it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants