Skip to content

Use actual return type in annotation for method submodule_update #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

Use actual return type in annotation for method submodule_update #2078

merged 1 commit into from
Oct 21, 2025
+1 −1

Conversation

@extrwi
Copy link

@extrwi extrwi commented Oct 21, 2025

Fixes #2077 "Return type mismatch in repo.submodule_update()"

Byron
Byron approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really does seem that it returns a RootModule 😁.
Let's try that.

@Byron Byron merged commit 271328f into gitpython-developers:main Oct 21, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Return type mismatch in repo.submodule_update()

3 participants

@extrwi @Byron @mtdcr