Fix commit hooks respecting core.hooksPath#2159
Open
Siesta0217 wants to merge 1 commit into
Open
Conversation
Use git rev-parse --git-path when resolving commit hook paths so GitPython follows Git's core.hooksPath configuration.\n\nAdd regression coverage for a pre-commit hook stored in a custom hooks path.\n\nFixes gitpython-developers#2083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git rev-parse --git-path hooks/<name>so GitPython follows Git'score.hooksPathconfiguration..git/hooksbehavior whencore.hooksPathis not configured.pre-commithook stored in a custom hooks path.Fixes #2083
Test Plan
python -m pytest test/test_index.py::TestIndex::test_pre_commit_hook_respects_core_hooks_path test/test_index.py::TestIndex::test_pre_commit_hook_success -q -o 'addopts='python -m pytest test/test_index.py::TestIndex::test_run_commit_hook test/test_index.py::TestIndex::test_pre_commit_hook_fail test/test_index.py::TestIndex::test_commit_msg_hook_success -q -o 'addopts='ruff check git/index/fun.py test/test_index.py