SQL reset error

[FreddieChopin]

I'm starting a new project and I had a folder src/chip with a Tupfile and some sourcefiles - at this point everything was working fine. I moved the chip with its contents down one level, to new src/board folder (which has nothing more but this chip folder at this moment), and tup decided to share such info with me:

>tup
[ tup ] [0.000s] Scanning filesystem...
[ tup ] [0.003s] Reading in new environment variables...
[ tup ] [0.004s] Parsing Tupfiles...
 1) [0.001s] src
 2) [0.001s] src\board
 [    ]  50%SQL reset error: UNIQUE constraint failed: normal_link.from_id, norm
al_link.to_id
Statement was: insert into normal_link(from_id, to_id) values(?, ?)
* 3) [0.002s] src\board\chip
tup error: Error parsing Tupfile line 14
  Line was: ': foreach $(ASSRCS) |> !as |>'
 [    ]  75%
 *** tup: 1 job failed.

The Tupfile I have is extremely simple:

include_rules

ASSRCS = *.S
CSRCS = *.c
CXXSRCS = *.cpp

: foreach $(ASSRCS) |> !as |>
: foreach $(CSRCS) |> !cc |>
: foreach $(CXXSRCS) |> !cxx |>

As you imagine !as, !cc and !cxx are the most standard macros that are possible... If I revert my change, the error remains - I have to delete .tup directory to make it go away. If I don't revert my changes, delete .tup directory and do an update it works fine. If I revert the change from this working state, it fails again with the same error.

I've used the most recent tup available (tup v0.7.1-4-gd6fe766). The behavior is the same on some older version of tup (from January).

Am I doing something wrong here? It usually worked perfectly fine when moving files around and now it doesn't... What additional info should I attach?

[gittup]

Hi Freddie,

On Tue, Apr 15, 2014 at 9:42 AM, freddiechopin notifications@github.comwrote:

I'm starting a new project and I had a folder src/chip with a Tupfile and
some sourcefiles - at this point everything was working fine. I moved the
chip with its contents down one level, to new src/board folder (which has
nothing more but this chip folder at this moment), and tup decided to share
such info with me:

tup
[ tup ] [0.000s] Scanning filesystem...
[ tup ] [0.003s] Reading in new environment variables...
[ tup ] [0.004s] Parsing Tupfiles...

1. [0.001s] src
2. [0.001s] src\board
   [ ] 50%SQL reset error: UNIQUE constraint failed: normal_link.from_id, norm
   al_link.to_id
   Statement was: insert into normal_link(from_id, to_id) values(?, ?)

• 3. [0.002s] src\board\chip
     tup error: Error parsing Tupfile line 14
     Line was: ': foreach $(ASSRCS) |> !as |>'
     [ ] 75%
     *** tup: 1 job failed.

The Tupfile I have is extremely simple:

include_rules

ASSRCS = *.S
CSRCS = *.c
CXXSRCS = *.cpp

: foreach $(ASSRCS) |> !as |>
: foreach $(CSRCS) |> !cc |>
: foreach $(CXXSRCS) |> !cxx |>

As you imagine !as, !cc and !cxx are the most standard macros that are
possible... If I revert my change, the error remains - I have to delete
.tup directory to make it go away. If I don't revert my changes, delete
.tup directory and do an update it works fine. If I revert the change from
this working state, it fails again with the same error.

I've used the most recent tup available (tup v0.7.1-4-gd6fe766). The
behavior is the same on some older version of tup (from January).

Am I doing something wrong here? It usually worked perfectly fine when
moving files around and now it doesn't... What additional info should I
attach?

Well this is definitely a bug. I'm not able to reproduce it based on your
description, though. Any idea what I'm missing? Here's my test case:

t6071

. ./tup.sh

tmkdir src
tmkdir src/board
tmkdir src/board/chip
cat > Tuprules.tup << HERE
!as = |> gcc -c %f -o %o |> %B.o
!cc = |> gcc -c %f -o %o |> %B.o
!cxx = |> g++ -c %f -o %o |> %B.o
HERE
cat > src/board/Tupfile << HERE
include_rules

ASSRCS = *.S
CSRCS = *.c
CXXSRCS = *.cpp

: foreach $(ASSRCS) |> !as |>
: foreach $(CSRCS) |> !cc |>
: foreach $(CXXSRCS) |> !cxx |>
HERE
tup touch src/board/foo.S
tup touch src/board/bar.S
update

mv src/board/*.S src/board/Tupfile src/board/chip
update

eotup

end t6071

Were you running the file monitor when this happened? Also, in the text you
mentioned moving src/board to src/chip, but it looks like it's
src/board/chip from the tup output?

Thanks,
-Mike

[FreddieChopin]

Yes, indeed my description was far from perfect. I've narrowed down the problem to its root cause.

Tuprules.tup:

TOP = $(TUP_CWD)
!cc = |> gcc -c %f -o %o |> $(TOP)/%B.o $(TOP)/<objects>

As you see I output the compiled file to the root directory of project and I put all objects in the group. If I remove either one of these ("$(TOP)/" prefix or "$(TOP)/") the problem is gone. There is no problem if the output goes to a subfolder of current folder - it has to be "$(TOP)/..." (note - "$(TOP)/sth/whatever/..." also causes the problem). The problem is gone if the group is not "absolute" - works, but $(TOP)/ doesn't.

I've also noticed that there is no need to actually move the folder somewhere else - it's enough to rename it.

Here is a link to my really simple test case - https://www.dropbox.com/s/kom1fk86rkzzhe7/tup-test-case.7z . Run that once, then rename "a" folder to "b" and re-run.

To have the error in your testcase I believe it's enough to change Tuprules.tup to something similar to what I have:

TOP = $(TUP_CWD)
!as = |> gcc -c %f -o %o |> $(TOP)/%B.o $(TOP)/<objects>
!cc = |> gcc -c %f -o %o |> $(TOP)/%B.o $(TOP)/<objects>
!cxx = |> g++ -c %f -o %o |> $(TOP)/%B.o $(TOP)/<objects>

Were you running the file monitor when this happened?

No, I'm on Windows, so the monitor feature is not available.

I hope that now I mentioned everything relevant (; Sorry for the earlier post, I had no time to analyze the problem precisely... It seems I have a talent for doing strange things with tup (;

[gittup]

Hi Freddie,

On Tue, Apr 15, 2014 at 4:00 PM, freddiechopin notifications@github.comwrote:

Yes, indeed my description was far from perfect. I've narrowed down the
problem to its root cause.

Tuprules.tup:

TOP = $(TUP_CWD)
!cc = |> gcc -c %f -o %o |> $(TOP)/%B.o $(TOP)/

As you see I output the compiled file to the root directory of project and
I put all objects in the group. If I remove either one of these ("$(TOP)/"
prefix or "$(TOP)/") the problem is gone. There is no problem if the output
goes to a subfolder of current folder - it has to be "$(TOP)/..." (note -
"$(TOP)/sth/whatever/..." also causes the problem). The problem is gone if
the group is not "absolute" - works, but $(TOP)/ doesn't.

I've also noticed that there is no need to actually move the folder
somewhere else - it's enough to rename it.

Here is a link to my really simple test case -
https://www.dropbox.com/s/kom1fk86rkzzhe7/tup-test-case.7z . Run that
once, then rename "a" folder to "b" and re-run.

To have the error in your testcase I believe it's enough to change
Tuprules.tup to something similar to what I have:

TOP = $(TUP_CWD)
!as = |> gcc -c %f -o %o |> $(TOP)/%B.o $(TOP)/
!cc = |> gcc -c %f -o %o |> $(TOP)/%B.o $(TOP)/
!cxx = |> g++ -c %f -o %o |> $(TOP)/%B.o $(TOP)/

Were you running the file monitor when this happened?

No, I'm on Windows, so the monitor feature is not available.

I hope that now I mentioned everything relevant (; Sorry for the earlier
post, I had no time to analyze the problem precisely... It seems I have a
talent for doing strange things with tup (;

Thanks for narrowing it down! That was indeed very helpful. Please give the
latest master a try, and continue to report any issues like this.

-Mike

[FreddieChopin]

It's working fine now - thanks! (;