Skip to content

Pushing throws pre-push hook error on repository with LFS. #2809

@argenkiwi

Description

@argenkiwi

Describe the bug
After updating to v0.28.0 I consistently receive the following error when attempting to push a change:

pre-push hook failed:
This should be run through Git's pre-push hook.  Run `git lfs update` to install it.

To Reproduce
Steps to reproduce the behavior:

  1. Press P

Expected behavior
Changes are pushed without error.

Context (please complete the following information):

  • OS/Distro + Version: macOS Tahoe version 26.1
  • GitUI Version 0.28.0
  • Rust version: not sure, installed via brew

Additional context

The repository that presents the issue uses LFS as recommended by the Paparazzi library.

Running git lfs update does not solve the issue. Removing .git/hooks/pre-push fixes the issue but obviously breaks LFS. Running git lfs update brings back the problem. Here are the contents of the generated pre-push hook:

#!/bin/sh
command -v git-lfs >/dev/null 2>&1 || { printf >&2 "\n%s\n\n" "This repository is configured for Git LFS but 'git-lfs' was not found on your path. If you no longer wish to use Git LFS, remove this hook by deleting the 'pre-push' file in the hooks directory (set by 'core.hookspath'; usually '.git/hooks')."; exit 2; }
git lfs pre-push "$@"

I also ensured to run chmod +x .git/hooks/pre-push but it made no difference.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions