Skip to content

Issue 2147#2384

Closed
dqkqd wants to merge 4 commits into
gitui-org:masterfrom
dqkqd:issue-2147
Closed

Issue 2147#2384
dqkqd wants to merge 4 commits into
gitui-org:masterfrom
dqkqd:issue-2147

Conversation

@dqkqd
Copy link
Copy Markdown

@dqkqd dqkqd commented Oct 8, 2024

This Pull Request fixes/closes #2147.

It will changes the following:

  • Disable edit [e] command when not at head revision
  • Add open [o] command to open the file if not at head revision
  • Add go to head [g] command to jump to that file at head revision (If exist)
  • Add proper error messages if tempfile cannot be created or opened ?
  • Add proper error messages if go to head failed due to file is not presented ?
  • Remove temporary file after close
  • Add unittests

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

dqkqd added 4 commits October 8, 2024 20:25
- Add new `selected_tree_file` function
- Use `selected_tree_file` inside `selection_changed`
Tempfiles are kept inside `tmp` directory and aren't getting deleted at the moment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

edit only for head revision otherwise open as tempfile

1 participant