Add test that fails because gix_repo does not take workdir into account yet #2790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I am not a huge believer in tests returning |
cruessler
force-pushed
the
add-failing-test-gix-repo-taking-workdir-into-account
branch
from
d5728e2 to
08384ce
Compare
Collaborator
Author
|
Sure! No objections, works for me. :-) |
Collaborator
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a separate PR adding the test case that is also part of #2789, hopefully showing that it fails on
master.I tried marking it with
#[should_panic], but then I would have had to refactor the test as the following error message would have forced me to change the return type to()which would have required me to turn all?into.unwrap(), so I decided to not add the annotation.