fix: reset only specific message state instead of entire parser#1
Merged
gituser865 merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
## Summary - Added `resetMessage(messageId: string)` method to `StreamingMessageParser` that clears only a single message's state from the internal messages map - Added `resetMessage(messageId: string)` override to `EnhancedStreamingMessageParser` that delegates to the parent and also clears the message's processed code blocks - Replaced the global `this.reset()` call (which wiped all message state) with the targeted `this.resetMessage(messageId)` when re-parsing with enhanced input ## Details Previously, when the enhanced parser detected and wrapped code blocks in a message, it called `this.reset()` which cleared the entire parser state for **all** messages before re-parsing. This was too broad and could discard valid state from other in-flight messages. The fix introduces a scoped `resetMessage` method at both the base and enhanced parser levels, ensuring only the specific message being re-parsed has its state cleared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompt Given
Fix the no response issue of the agents during conversation with them in the repository
Summary
resetMessage(messageId: string)method toStreamingMessageParserthat clears only a single message's state from the internal messages mapresetMessage(messageId: string)override toEnhancedStreamingMessageParserthat delegates to the parent and also clears the message's processed code blocksthis.reset()call (which wiped all message state) with the targetedthis.resetMessage(messageId)when re-parsing with enhanced inputDetails
Previously, when the enhanced parser detected and wrapped code blocks in a message, it called
this.reset()which cleared the entire parser state for all messages before re-parsing. This was too broad and could discard valid state from other in-flight messages.The fix introduces a scoped
resetMessagemethod at both the base and enhanced parser levels, ensuring only the specific message being re-parsed has its state cleared.View more about this proposed fix in the CircleCI web app →