Skip to content

Fixed a crash on iPhone 6 and newer devices #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giulio92 merged 3 commits into from
Dec 20, 2016
Merged

Fixed a crash on iPhone 6 and newer devices #7

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0ae5c4
- Fixed a crash on iPhone 6 and newer devices, the GLIndexedCollectio…
giulio92 Dec 20, 2016
f241d49
Merge branch 'hotfix/weakCollectionViewRelease'
giulio92 Dec 20, 2016
2c5033a
Merge tag 'weakCollectionViewRelease' into develop
giulio92 Dec 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions GLTableCollectionView/GLCollectionTableViewCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,13 @@ class GLCollectionTableViewCell: UITableViewCell {

It's recommended to keep the variable `public` so it would be easier to
access later in the code, for example in UITableView's `dataSource` and
`delegate` methods. For light to mid-heavy implementations `weak` is also
suggested.
`delegate` methods.

GLIndexedCollectionView requires a `strong` ARC reference, do not assign a
`weak` reference otherwise it could result in a crash.

*/
weak var collectionView: GLIndexedCollectionView!
var collectionView: GLIndexedCollectionView!
var collectionFlowLayout: GLIndexedCollectionViewFlowLayout!

/**
Expand Down