Skip to content

Fix interval generation inconsistency between naive and intersection tree implementations #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gjbex merged 2 commits into from
Sep 11, 2025
Merged

Fix interval generation inconsistency between naive and intersection tree implementations #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c37e77
Initial plan
Copilot Sep 11, 2025
a43ed9a
Fix interval generation bug in intersection_tree.py
Copilot Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source_code/intersection_trees/intersection_tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def generate_interval(max_end: int = 1_000_000_000) -> Interval:
Returns
-------
Interval
Tuple (start, end) such that end - start >= 1
Tuple (start, end) such that end - start > 1

Raises
------
Expand All @@ -159,7 +159,7 @@ def generate_interval(max_end: int = 1_000_000_000) -> Interval:
raise ValueError(f"max_end must be at least 2, got {max_end}")

start = random.randint(0, max_end - 2)
end = random.randint(start + 1, max_end)
end = random.randint(start + 2, max_end)
return start, end


Expand Down