Add matrix4#46
Merged
Merged
Conversation
Contributor
|
不要提交无关文件 |
CoraBlack
requested changes
Apr 24, 2026
…into feature/math
…ations into .cpp files and adding comprehensive English comments.
CoraBlack
requested changes
Apr 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces new 3x3 and 4x4 matrix implementations to gkit::math (including common transforms/projections) and wires them into the build, along with a new Matrix4 test executable.
Changes:
- Add
Matrix4API + implementation (transform/projection/decomposition helpers). - Add out-of-line
Matrix3implementation and include both matrix sources insrc/math/CMakeLists.txt. - Minor Vector3/Vector4 operator const-correctness update and a new
test_matrix4executable.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| test/math/test_matrix4.cpp | Adds a standalone Matrix4 test/demo executable exercising many Matrix4 APIs. |
| src/math/vector4.cpp | Adds definition for Vector4 rvalue-ref constructor. |
| src/math/vector3.cpp | Adds definition for Vector3 rvalue-ref constructor. |
| src/math/matrix4.cpp | Adds the full Matrix4 implementation (mul/inverse/projection/etc.). |
| src/math/matrix3.cpp | Adds the Matrix3 implementation moved out of the header. |
| src/math/CMakeLists.txt | Registers matrix3.cpp/matrix4.cpp in the math object library build. |
| include/gkit/math/vector4.hpp | Makes Vector4 +/- operators const. |
| include/gkit/math/vector3.hpp | Makes Vector3 +/- operators const. |
| include/gkit/math/matrix4.hpp | Adds the Matrix4 public API. |
| include/gkit/math/matrix3.hpp | Refactors Matrix3 header to use out-of-line definitions and adds comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
已按照Copilot建议修改,具体效果需要根据相机系统验证 |
…n documentation to all math headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.