Skip to content

Add matrix4#46

Merged
CoraBlack merged 8 commits into
gkit-org:mainfrom
YuanSang0512:feature/math
Apr 26, 2026
Merged

Add matrix4#46
CoraBlack merged 8 commits into
gkit-org:mainfrom
YuanSang0512:feature/math

Conversation

@YuanSang0512

Copy link
Copy Markdown
Contributor

No description provided.

@CoraBlack

Copy link
Copy Markdown
Contributor

不要提交无关文件

Comment thread test/math/test_matrix4.cpp Outdated
Comment thread include/gkit/math/matrix4.hpp Outdated
Comment thread include/gkit/math/matrix4.hpp Outdated

@CoraBlack CoraBlack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

类与方法注释应使用 doxygen 文档格式

接下来,我会使用copilot进行功能性上的问题排查

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces new 3x3 and 4x4 matrix implementations to gkit::math (including common transforms/projections) and wires them into the build, along with a new Matrix4 test executable.

Changes:

  • Add Matrix4 API + implementation (transform/projection/decomposition helpers).
  • Add out-of-line Matrix3 implementation and include both matrix sources in src/math/CMakeLists.txt.
  • Minor Vector3/Vector4 operator const-correctness update and a new test_matrix4 executable.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
test/math/test_matrix4.cpp Adds a standalone Matrix4 test/demo executable exercising many Matrix4 APIs.
src/math/vector4.cpp Adds definition for Vector4 rvalue-ref constructor.
src/math/vector3.cpp Adds definition for Vector3 rvalue-ref constructor.
src/math/matrix4.cpp Adds the full Matrix4 implementation (mul/inverse/projection/etc.).
src/math/matrix3.cpp Adds the Matrix3 implementation moved out of the header.
src/math/CMakeLists.txt Registers matrix3.cpp/matrix4.cpp in the math object library build.
include/gkit/math/vector4.hpp Makes Vector4 +/- operators const.
include/gkit/math/vector3.hpp Makes Vector3 +/- operators const.
include/gkit/math/matrix4.hpp Adds the Matrix4 public API.
include/gkit/math/matrix3.hpp Refactors Matrix3 header to use out-of-line definitions and adds comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/math/matrix4.cpp
Comment thread include/gkit/math/matrix4.hpp Outdated
Comment thread include/gkit/math/matrix3.hpp Outdated
Comment thread src/math/matrix4.cpp Outdated
Comment thread src/math/matrix4.cpp
Comment thread src/math/matrix4.cpp
Comment thread src/math/matrix4.cpp Outdated
Comment thread include/gkit/math/matrix4.hpp Outdated
@YuanSang0512

Copy link
Copy Markdown
Contributor Author

已按照Copilot建议修改,具体效果需要根据相机系统验证

@CoraBlack CoraBlack merged commit 527ff93 into gkit-org:main Apr 26, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in libgkit-dev-record Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants