gh-363: fix flakiness of test_ellipticity_gaussian #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntessore
reviewed
Oct 15, 2024
Collaborator
ntessore
left a comment
ntessore
left a comment
There was a problem hiding this comment.
I disagree with this fix. For a non-truncated Gaussian, the chance of this test failing is something like 3.3e-8 -- if we are seeing noticeably more failures than that, I should investigate whether the function isn't actually broken. But for a sample size
Comment on lines
96
to
+97
| np.testing.assert_allclose(np.std(eps.real), 0.256, atol=1e-3, rtol=0) | ||
| np.testing.assert_allclose(np.std(eps.imag), 0.256, atol=1e-3, rtol=0) | ||
| np.testing.assert_allclose(np.std(eps.imag), 0.256, atol=1e-2, rtol=0) |
Collaborator
There was a problem hiding this comment.
Why is this only changing the imaginary component?
Member
Author
|
Oops, should have waited for a review. If the chance of it failing is that low (maybe that's why we noticed it 1.5 months into the project), I will just revert and use |
Saransh-cpp
added a commit
that referenced
this pull request
Oct 18, 2024
…371) Rerun the flaky test if it fails. See #364 (comment) Closes: #363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the tolerance for the test to pass always.
Closes: #363