gh-430: fix for release action

[ntessore]

This should fix the release action. The git tag is stored into the environment after the README.md is made dirty, where setuptools-scm picks it up as the current version.

Closes: #430

[Saransh-cpp]

Thanks for looking into this, @ntessore!

[paddyroddy]

Good spot @ntessore. I'd overlook this 🤔. Your approach is nice and simple.

We could actually fix the "dirty" checkout by doing something like this

- name: Update version references
  run: |-
    # store the release tag
    tag="${{ github.ref_name }}"
    
    # regex patterns
    badge_pattern="s#(readthedocs\.org/projects/glass/badge/\?version=)stable#\1${tag}#g"
    url_pattern="s#(glass\.readthedocs\.io.*?)/stable#\1/${tag}#g"
    
    # perform the replacements
    sed --in-place --regexp-extended \
      --expression "$badge_pattern" \
      --expression "$url_pattern" \
      ${{ github.workspace }}/README.md
      
- name: Upload modified README
  uses: actions/upload-artifact@v3
  with:
    name: modified-readme
    path: README.modified

And downloading the README.modified as README.md in a subsequent step. What do you think?