Skip to content

Add support for array destructuring#142

Merged
ichiriac merged 2 commits into
glayzzle:masterfrom
czosel:array-destructuring
Mar 26, 2018
Merged

Add support for array destructuring#142
ichiriac merged 2 commits into
glayzzle:masterfrom
czosel:array-destructuring

Conversation

@czosel

@czosel czosel commented Mar 24, 2018

Copy link
Copy Markdown
Collaborator

I finally dared (and found the time) to take a closer look at the parser 😄 I'm curious to hear your feedback!

Fixes #121

@czosel czosel requested a review from ichiriac March 24, 2018 17:37
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 94.772% when pulling 607708c on czosel:array-destructuring into 82233e9 on glayzzle:master.

@ichiriac ichiriac added this to the 3.0.0 milestone Mar 26, 2018
@ichiriac ichiriac merged commit 1534eca into glayzzle:master Mar 26, 2018
ichiriac added a commit that referenced this pull request Mar 26, 2018
@ichiriac

Copy link
Copy Markdown
Member

Hi @czosel,

I've read carefully your changes, and the algorithm is perfect 💯

I only need to make a small change, I need that array deferencing behaves as list, so I'll use the same node in order to make it more easier to handle nodes translations for example (and keep a property for the semantics part)

Again, many thanks for your help

@czosel czosel deleted the array-destructuring branch March 26, 2018 19:49
@czosel

czosel commented Mar 26, 2018

Copy link
Copy Markdown
Collaborator Author

☺️ great! Thanks for the review and the merge - I’ll take a look at your changes concerning the list node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support array destructuring

3 participants