Skip to content

Conversation

@Pi-Cla
Copy link

@Pi-Cla Pi-Cla commented Apr 12, 2024

Fixes a RUSTSEC advisory where mockito was depending on an unmaintained crate
lipanski/mockito#145

Fixes a RUSTSEC advisory where mockito was depending
on an unmaintained crate
lipanski/mockito#145
@Pi-Cla
Copy link
Author

Pi-Cla commented Apr 12, 2024

Bumping it further requires us to rewrite some stuff due to breaking changes (whereas I mainly just want to make sure we are not depending on any unmaintained crates)

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! I think this doesn't upgrade mockito, the upper bound is the same before and after this commit.

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html

@Pi-Cla
Copy link
Author

Pi-Cla commented Apr 23, 2024

Hello! I think this doesn't upgrade mockito, the upper bound is the same before and after this commit.

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html

Looking at cargo reference you linked it lists this:

0.2    :=  >=0.2.0, <0.3.0

mockito is a v0 package so a dependency on 0.30.0 means it can not be increased to 0.31.1.
The dependency currently is:

0.30    :=  >=0.30.0, <0.31.0

This will bump it up to:

0.31.1    :=  >=0.31.1, <0.32.0

@Pi-Cla Pi-Cla mentioned this pull request Apr 23, 2024
@lpil
Copy link
Member

lpil commented Apr 26, 2024

Ah! I missed the v0 bit. Thank you for explaining that to me

@lpil lpil merged commit 32fab65 into gleam-lang:main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants