feat: add atomic file write utility and use it consistently#87
Merged
Conversation
steve-calvert-glean
force-pushed
the
atomic-writes
branch
from
61dab14 to
2841f9e
Compare
rwjblue-glean
approved these changes
Apr 12, 2026
Extract the tmp+rename atomic write pattern from auth/storage.go into a shared fileutil.WriteFileAtomic function. Update session.Save(), config.saveToFile(), and auth writeJSON() to use it, preventing file corruption from crashes mid-write.
steve-calvert-glean
force-pushed
the
atomic-writes
branch
from
2841f9e to
c394d3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auth/storage.gointo a sharedfileutil.WriteFileAtomicutilitysession.Save(),config.saveToFile(), andauth.writeJSON()to use itTest plan
mise run test:allpasses (453 tests, lint clean, binary builds)