feat: add structured CLI errors with distinct exit codes#90
Merged
Conversation
Introduces CLIError type carrying user message, suggestion, exit code, and cause. Scripts wrapping glean can now distinguish auth failures (exit 3) from network errors (exit 4) from API errors (exit 5). Converts authError() to use CLIError as the first adopter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rwjblue-glean
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLIErrortype ininternal/errors/carrying user message, suggestion, exit code, and causeauthError()in cmd/root.go now returns aCLIErrorinstead of printing to stderr + returningerrSilentExecute()andmain.goextract exit codes fromCLIErrorTest plan
CLIError.Error()with and without suggestionUnwrap()returns causeerrors.Asworks withCLIErrormise run test:allpasses (455 tests, lint clean, binary builds)