fix: deployment pipeline #81
Merged
+26
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove auto-trigger-code-samples and instead run generate-code-samples
every 4 hours.
The previous setup would trigger generate-code-samples, but none of the
downstream workflows (the next one being .github/workflows/deploy-pages.yml).
The rules for GitHub are as follows:
If workflow A triggers workflow B in a way that is "automated", then B
will run but its completion will not trigger downstream workflows C.
"automated" here is determined by the use of `GITHUB_TOKEN`
gh workflow run generate-code-samples.yml
implicitly uses `GITHUB_TOKEN`.
The current setup means that most of the pipeline runs redundantly (e.g.
we will generate code samples and check them in even with no changes) up
until the glean developer site's trigger-redeploy.yml[^1] which exits
early if there are no changes.
[1]: https://github.com/gleanwork/glean-developer-site/blob/8fa1fb6cfb44c457ed135eca678d7a9da82af4f4/.github/workflows/trigger-redeploy.yml#L1-L115
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a04ed88c64
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
travis-hoover-glean
approved these changes
Jan 15, 2026
Fix steps.check.clients_ready -> steps.check.outputs.clients_ready and fix prettier formatting.
Manual triggers should always run, regardless of client sync status. The check only gates scheduled (cron) runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove auto-trigger-code-samples and instead run generate-code-samples every 4 hours.
The previous setup would trigger generate-code-samples, but none of the downstream workflows (the next one being .github/workflows/deploy-pages.yml).
The rules for GitHub are as follows:
If workflow A triggers workflow B in a way that is "automated", then B will run but its completion will not trigger downstream workflows C.
"automated" here is determined by the use of
GITHUB_TOKENimplicitly uses
GITHUB_TOKEN.The current setup means that most of the pipeline runs redundantly (e.g.
we will generate code samples and check them in even with no changes) up
until the glean developer site's trigger-redeploy.yml[^1] which exits
early if there are no changes.