Skip to content

Added possibility to specify services in the post body.#5

Open
endareBrock wants to merge 1 commit into
gleerman:masterfrom
endareBrock:feature/deployByService
Open

Added possibility to specify services in the post body.#5
endareBrock wants to merge 1 commit into
gleerman:masterfrom
endareBrock:feature/deployByService

Conversation

@endareBrock
Copy link
Copy Markdown

Added possibility to specify services in the post body.
Adjusted README.md

@gleerman
Copy link
Copy Markdown
Owner

The change is not backward compatible. When not providing a body with services, the server returns 400 Bad Request.

Secondary, I think there is a security issue where the external users of the service can inject commands through the body of the request. For example: the body {"services": "; uname"} should not be valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants