Skip to content

Don't return non-primitives from Excel#155

Merged
schani merged 4 commits intomasterfrom
fix-ffp-results
Sep 27, 2023
Merged

Don't return non-primitives from Excel#155
schani merged 4 commits intomasterfrom
fix-ffp-results

Conversation

@schani
Copy link
Copy Markdown
Member

@schani schani commented Sep 26, 2023

fast-formula-parser can return non-primitives such as arrays, but also error objects, none of which we want to, or are allowed to, return.

This might be the reason why the Excel column is slow, but that's a guess.

@schani schani requested a review from jassmith September 26, 2023 20:25
@schani schani enabled auto-merge September 26, 2023 20:43
@schani schani requested a review from jassmith September 26, 2023 23:03
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
glide-code-columns ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 0:07am

@schani schani merged commit 4908bfe into master Sep 27, 2023
@schani schani deleted the fix-ffp-results branch September 27, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants