Skip to content

feat: 🏷️ add deprecated fields to JSON and fetch#159

Merged
timwellswa merged 6 commits intomasterfrom
add-deprecation-label
Oct 6, 2023
Merged

feat: 🏷️ add deprecated fields to JSON and fetch#159
timwellswa merged 6 commits intomasterfrom
add-deprecation-label

Conversation

@cif
Copy link
Copy Markdown
Contributor

@cif cif commented Oct 3, 2023

This is being done as part of Glide tasks:

Includes a deprecation banner on the REPL beautifully designed by ChatGPT:

image

Update, this may also deprecate Fetch as well, TBD based on @parkxdavid expert discovery

https://github.com/glideapps/glide/issues/21604

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
glide-code-columns ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 2:22pm

@timwellswa timwellswa merged commit 3053f78 into master Oct 6, 2023
@timwellswa timwellswa deleted the add-deprecation-label branch October 6, 2023 14:16
@djpirl
Copy link
Copy Markdown

djpirl commented Oct 6, 2023

To clarify, this is the deprecation approach where the developer cannot add new instances?

Is this the general pattern we are taking, or is this specific to these columns?

@cif
Copy link
Copy Markdown
Contributor Author

cif commented Oct 6, 2023

Is this the general pattern we are taking, or is this specific to these columns?

This is yet another set of columns that works differently from the internal plugin system and the older built in options. Still thinking through how to better unify them if at all possible.

Some data around how widely used these columns are in particular would be interesting, happy to try and pair on wether or not that's easy to surface or not

@djpirl
Copy link
Copy Markdown

djpirl commented Oct 6, 2023

Is this the general pattern we are taking, or is this specific to these columns?

This is yet another set of columns that works differently from the internal plugin system and the older built in options. Still thinking through how to better unify them if at all possible.

Some data around how widely used these columns are in particular would be interesting, happy to try and pair on wether or not that's easy to surface or not

To clarify my question, what is going to happen to developers who have apps using these columns?

Option A

  • Columns still work
  • New instances can be added

Option B

  • Columns still work
  • New instances cannot be added

The banner suggests to me that it's Option B. However, I thought we discussed pursuing Option A. CC @rwdaigle

@rwdaigle
Copy link
Copy Markdown

rwdaigle commented Oct 6, 2023

Correct. We do want Option A to be our definition of deprecated

@djpirl
Copy link
Copy Markdown

djpirl commented Oct 6, 2023

Correct. We do want Option A to be our definition of deprecated

In this scenario, what user experience did we merge?

@cif
Copy link
Copy Markdown
Contributor Author

cif commented Oct 6, 2023 via email

@djpirl
Copy link
Copy Markdown

djpirl commented Oct 9, 2023

If I'm tracking you correctly, this is upfront work before we ship this banner to users?

@cif
Copy link
Copy Markdown
Contributor Author

cif commented Oct 9, 2023

If I'm tracking you correctly, this is upfront work before we ship this banner to users?

Exactly. The column configurations in this repo get consumed remotely via their metadata residing at this URL: https://column.sh/all.json

@djpirl
Copy link
Copy Markdown

djpirl commented Oct 9, 2023

Got it. I can change the copy of this banner as it is not exactly right then

@cif
Copy link
Copy Markdown
Contributor Author

cif commented Oct 9, 2023

That banner only shows up on column.sh website (in this repo).

Seems like the idea here was to open up the ability for open source contributors to create computed columns

@cif
Copy link
Copy Markdown
Contributor Author

cif commented Oct 9, 2023

I just noticed a comment in one of the deprecation issues from @rwdaigle regarding deprecation (not even apps with existing uses will show the column any more).

Would you like me to update the copy to reflect this strategy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants