feat: ⏪ dont deprecate json fetch#161
Merged
timwellswa merged 3 commits intomasterfrom Oct 12, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
djpirl
reviewed
Oct 10, 2023
Co-authored-by: DJP <parkxdavid@gmail.com>
ivoelbert
approved these changes
Oct 11, 2023
Contributor
ivoelbert
left a comment
ivoelbert
left a comment
There was a problem hiding this comment.
The code looks fine, but I don't see why we wouldn't deprecate this. It feels like we should deprecate it. cc @parkxdavid
We had multiple discussions about this yesterday 😆 The team is aligned on this definition of deprecation. Notion: https://www.notion.so/glideapps/Product-Release-Stages-Deprecation-2d100b174d644fdd9d773cfc7f714da0?pvs=4#e08190c1982a46f192b2c9e1542d9ac2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want to deprecate JSON fetch yet, since the new alternative is not available on the Free plan.